chore(maitake): use stdlib pin! and poll_fn
#486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we use the versions of `pin_mut!`, `future::poll_fn`, and `future::ready` from the `futures` crate. Now, `core::pin::pin!`, `core::future::poll_fn`, and `core::future::ready` are stable, so we can are stable, so we can just use the stdlib versions of these APIs instead. This allows us to reduce our dev dependencies on the `futures` crates down to just depending on `futures_util` in `maitake-sync` for `select_biased!`. Reducing the number of dev-deps will hopefully make compiling the tests a little faster. And, the stdlib version of `pin!` is *way* nicer than `futures::pin_mut!` as it can be on the right-hand side of an assignment, rather than requiring an assignment followed by a `pin!`.
hawkw
force-pushed
the
eliza/use-std-futures
branch
from
3d8c590 to
a7493cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use the versions of
pin_mut!andfuture::poll_fnfrom thefuturescrate. Now,core::pin::pin!andcore::future::poll_fnare stable, so we can just use the stdlib versions of these APIs instead.This allows us to reduce our dev dependencies on the
futurescrates down to just depending onfutures_utilinmaitake-syncforselect_biased!. Reducing the number of dev-deps will hopefully make compiling the tests a little faster. And, the stdlib version ofpin!is way nicer thanfutures::pin_mut!as it can be on the right-hand side of an assignment, rather than requiring an assignment followed by apin!.