StreamParserObject::eof returns an Option #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly changed the following:
Rationale: an eof of a stream might come "detached" from any data. For example for signal stream the
Data
andEnd
signal are always separated. In that case, there could be no data to process (if the previous chunks are complete and already get emitted) and thus no result to emit ineof()
and the current API is unable to express that.Breaking change: added
function readEof():Outcome<Option<Result>, Error>
to BytewiseParser and the eof is no longer handled with a-1
byte.At the same time, I updated/simplified
Splitter
implementation to useChunkCursor::seek