Use latest release from beginning #16
Conversation
| @@ -123,7 +123,7 @@ export PATH="${PWD}/depot_tools:${PATH}" | |||
| cd skia | |||
|
|
|||
| # get proper skia's branch to compile | |||
| SKIA_BRANCH=$(curl "https://raw.githubusercontent.com/aseprite/aseprite/master/INSTALL.md" | grep "aseprite-m[0-9][0-9]" | sed -n '1p' | perl -n -e '/(aseprite-m\d\d)/ && print $1') | |||
| SKIA_BRANCH=$(curl "https://raw.githubusercontent.com/aseprite/aseprite/main/INSTALL.md" | grep "aseprite-m[0-9][0-9]" | sed -n '1p' | perl -n -e '/(aseprite-m\d\d)/ && print $1') | |||
There was a problem hiding this comment.
This is arguably still wrong, since it's not using the tag. I think it's probably okay for now.
There was a problem hiding this comment.
Thanks. This one is good. aseprite really changes the structure of branches included separation of release and beta version.
Edit:
Yeah, I kinda agree, it's ideal to base on specific tag to parse the content from.
| @@ -3,7 +3,7 @@ | |||
| # Script to automate building latest release of Aseprite (it can be release or beta build) | |||
| # This is for macOS build version. | |||
|
|
|||
| POSTFIXPATH_SDKROOT=Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk | |||
| POSTFIXPATH_SDKROOT=Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk | |||
There was a problem hiding this comment.
It should be fine to use the current installed SDK, rather than requiring an old one...
There was a problem hiding this comment.
I'm skeptical about this as it relates to #11 , I think we should not touch this for now.
|
@klep I did check and upstream aseprite changed git branch structure to hold normal release (stable version), and beta version into separate branch. They are respectively I believe we would need to modify will return a correct result for the latest recent tag corresponding to which branch such tag coming from. Now it return unexpected tag. Do you want to work on this yourself or I can do it from my side? regarding to the following changes
Feel free to let me know! Thanks! |
haxpor
added
enhancement
upstream-changed
|
Happy to handle it either way. I suspect this isn't a full time focus for either of us, so maybe just whomever gets to it first? I'll have some in a few weeks, but won't be offended if you make the fix without me :) |
|
Thanks @klep . I asked to respect your initiation, and continued effort in making changes. I'll do it but will mention and link in your finding/effort in the commit message. Thank you again :) I close this issue for now. The proper fix will be worked on later. |
|
This can be tracked at #17 |
The branch
masterno longer exists in the repo -- it has been renamedmain. However, I think we're better off using the latest tag, since that's what's used later when we do the final build.