Ported more tests [3/6] #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a bug where an asyncio Lock was tried to be acquired without a release - Store asyncio tasks in order not to lose them - Removed start/shutdown from AsyncioReactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 93.55% 94.02% +0.47%
==========================================
Files 389 389
Lines 24435 24434 -1
==========================================
+ Hits 22861 22975 +114
+ Misses 1574 1459 -115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuce
changed the title
yuce
changed the title
yuce
changed the title
yuce
changed the title
yuce
commented
Nov 25, 2025
|
|
||
| async def test_heartbeat_stopped_and_restored(self): | ||
| member2 = self.rc.startMember(self.cluster.id) | ||
| # TODO: remove this |
Contributor
Author
There was a problem hiding this comment.
emreyigit
reviewed
Nov 26, 2025
| from tests.util import random_string | ||
|
|
||
|
|
||
| class ConnectionStrategyTest(unittest.IsolatedAsyncioTestCase, HazelcastTestCase): |
Member
There was a problem hiding this comment.
Why did you remove async start tests? I think these can be used on async client without awating to see client's reaction.
Contributor
Author
There was a problem hiding this comment.
Asyncio client doesn't support async start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.