additional configuration for NoCallbacksInFunctions, upgrade Kotlin

README.md

@@ -14,7 +14,7 @@ These are my opinions. There are many like them but these are mine. 😄
 
 Inside of your `dependencies` block add the following: (for more details see [adding more rule sets](https://github.com/detekt/detekt#adding-more-rule-sets))
 ```kotlin 
-detektPlugins("com.github.hbmartin:hbmartin-detekt-rules:0.1.0")
+detektPlugins("com.github.hbmartin:hbmartin-detekt-rules:0.1.1")
 ```
 
 Then add to your detekt configuration as in the section below to activate rules. Note that the AvoidFirstOrLastOnList and AvoidMutableCollections rules require [type resolution](https://detekt.dev/docs/gettingstarted/type-resolution) to be active.
@@ -41,6 +41,8 @@ HbmartinRuleSet:
   NoCallbacksInFunctions:
     active: true
     ignoreAnnotated: ['Composable']
+    allowExtensions: true
+    allowReceivers: true
   NoNotNullOperator:
     active: true
   NoVarsInConstructor:

build.gradle.kts

@@ -1,5 +1,5 @@
 plugins {
-    kotlin("jvm") version "1.9.0"
+    kotlin("jvm") version "1.9.10"
     `maven-publish`
     id("io.gitlab.arturbosch.detekt").version("1.23.1")
     jacoco

src/main/kotlin/me/haroldmartin/detektrules/NoCallbacksInFunctions.kt

@@ -7,9 +7,11 @@ import io.gitlab.arturbosch.detekt.api.Entity
 import io.gitlab.arturbosch.detekt.api.Issue
 import io.gitlab.arturbosch.detekt.api.Rule
 import io.gitlab.arturbosch.detekt.api.Severity
+import io.gitlab.arturbosch.detekt.api.config
 import org.jetbrains.kotlin.psi.KtFunctionType
 import org.jetbrains.kotlin.psi.KtNamedFunction
 import org.jetbrains.kotlin.psi.KtParameter
+import org.jetbrains.kotlin.psi.psiUtil.isExtensionDeclaration
 
 class NoCallbacksInFunctions(config: Config) : Rule(config) {
     override val issue = Issue(
@@ -19,17 +21,34 @@ class NoCallbacksInFunctions(config: Config) : Rule(config) {
         debt = Debt.TWENTY_MINS,
     )
 
+    @Suppress("BooleanPropertyNaming")
+    private val allowReceivers: Boolean by config(true)
+
+    @Suppress("BooleanPropertyNaming")
+    private val allowExtensions: Boolean by config(true)
+
     override fun visitNamedFunction(function: KtNamedFunction) {
         super.visitNamedFunction(function)
-        function.functionTypeParameters?.takeIf { it.isNotEmpty() }?.let {
-            report(
-                CodeSmell(
-                    issue = issue,
-                    entity = Entity.from(function),
-                    message = "${function.name} should not have callbacks: ${it.joinToString()}",
-                ),
-            )
-        }
+        if (allowExtensions && function.isExtensionDeclaration()) return
+        function
+            .functionTypeParameters
+            ?.mapNotNull { paramText ->
+                if (paramText.contains(".(") && allowReceivers) {
+                    null
+                } else {
+                    paramText
+                }
+            }
+            ?.takeIf { it.isNotEmpty() }
+            ?.let {
+                report(
+                    CodeSmell(
+                        issue = issue,
+                        entity = Entity.from(function),
+                        message = "${function.name} should not have callbacks: ${it.joinToString()}",
+                    ),
+                )
+            }
     }
 }
 

src/main/resources/config/config.yml

@@ -19,5 +19,8 @@ HbmartinRuleSet:
   NoCallbacksInFunctions:
     active: true
     ignoreAnnotated: ['Composable']
+    allowExtensions: true
+    allowReceivers: true
+
   WhenBranchSingleLineOrBraces:
     active: true

src/test/kotlin/me/haroldmartin/detektrules/NoCallbacksInFunctionsTest.kt

@@ -50,4 +50,27 @@ internal class NoCallbacksInFunctionsTest(private val env: KotlinCoreEnvironment
         val findings = NoCallbacksInFunctions(Config.empty).compileAndLintWithContext(env, code)
         findings shouldHaveSize 1
     }
+
+    @Test
+    fun `does not report extension function`() {
+        val code = """
+private fun List<T>.forEach(function: (T) -> Unit) {
+    for (i in 0 until length) {
+        function(item(i))
+    }
+}
+        """
+        val findings = NoCallbacksInFunctions(Config.empty).compileAndLintWithContext(env, code)
+        findings shouldHaveSize 0
+    }
+
+    @Test
+    fun `does not report receiver function`() {
+        val code = """
+fun mydsl(function: String.() -> Unit) {
+}
+        """
+        val findings = NoCallbacksInFunctions(Config.empty).compileAndLintWithContext(env, code)
+        findings shouldHaveSize 0
+    }
 }