Add Vietnamese (vi) locale to UI and language selector #10110
+119
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… language lists (desktop, prod)\n- Add Vietnamese label to UI plugin strings\n- Update SettingsPopup to show Vietnamese option\n- Provide packages/ui/lang/vi.json translations\n\nThis enables Vietnamese language selection and core UI translations.
|
Connected to Huly®: UBERF-13955 |
|
Hi @huytu250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n- Adds Vietnamese (vi) locale support to the UI.\n\nChanges\n- Add 'vi' to default language lists in desktop and prod configs.\n- Introduce ui.string.Vietnamese and wire it into SettingsPopup.\n- Update SettingsPopup to include 'vi' option and appropriate flag.\n- Provide packages/ui/lang/vi.json with complete translations based on en.json.\n\nBehavior\n- Language picker now shows 'Tiếng Việt'.\n- UI strings render in Vietnamese where available; per-key fallback remains English as designed.\n\nVerification\n- Ran webpack dev server locally and verified language selection and core UI strings on http://localhost:8080/.\n- No build errors observed.\n\nNotes\n- Other packages (outside UI) continue to fall back to English until their vi.json files are added.\n- No breaking changes; metadata Languages updated to include 'vi'.