feat(love): enable transcription language selector and restore Deepgram language support#10533
Open
spatialy wants to merge 1 commit intohcengineering:developfrom
Open
Conversation
…am language support The RoomLanguageSelector component (45 languages, flag emojis) was fully built but commented out in RoomTranscriptionSettings.svelte, so all rooms defaulted to English with no way to change it from the UI. OpenAI STT users in non-English environments received garbled output (~30% confidence). - RoomTranscriptionSettings.svelte: uncomment the language selector row; add missing imports for the ui plugin reference and RoomLanguageSelector - AddRoomPopup.svelte: replace hardcoded 'en' default with browser locale (navigator.language), falling back to 'en' when the locale is not in the supported language list - deepgram/stt.ts: restore updateLanguage() stop/restart implementation and wire this.language through getOptions() so Deepgram users can override the 'multi' auto-detect default with a specific language when needed; default remains 'multi' to preserve existing behaviour Fixes hcengineering#10532 Signed-off-by: Yulian Diaz <5605867+spatialy@users.noreply.github.com>
|
Connected to Huly®: UBERF-15625 |
Member
|
Hi @kristina-fefelova |
Member
|
We did not use language selector because we use the nova-3 model with automatic language detection (English, Spanish, French, German, Hindi, Russian, Portuguese, Japanese, Italian and Dutch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10532.
The
RoomLanguageSelectorcomponent was fully built (45 languages, flag emojis, live update viaclient.diffUpdate) but commented out inRoomTranscriptionSettings.svelte, so every room defaulted to English with no way to change it from the UI. OpenAI STT users in non-English environments received garbled output with ~30% confidence scores.Changes
plugins/love-resources/src/components/RoomTranscriptionSettings.svelteantiGrid-rowthat was blocked behind<!-- ... -->ui(plugin reference, forui.string.Language) andRoomLanguageSelectorplugins/love-resources/src/components/AddRoomPopup.sveltelanguage: 'en'withgetDefaultLanguage()which readsnavigator.languagezh-TW,en-GB, …), falls back to base language (zh,en, …), then to'en'if not in the supported listservices/ai-bot/love-agent/src/deepgram/stt.tsprivate language: string = 'multi'(default preserves existing Nova-3 auto-detect behaviour)updateLanguage()stop/restart implementation so language changes propagate to active connectionsthis.languagethroughgetOptions()instead of hardcoded'multi'processTrackBehaviour after this change
'en''en')'en'→ garbled for non-English'multi'(hardcoded)'multi'by default; follows room language if changedTest plan
'multi'auto-detect is unchanged