Skip to content

Conversation

utkaka
Copy link
Contributor

@utkaka utkaka commented Sep 25, 2025

  • Moved pulse client initialization to the presentation package
  • Replaced transient JoinRequest and Invite objects with pulse-based messaging

Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Copy link

Connected to Huly®: UBERF-13778

Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>

# Conflicts:
#	plugins/love-resources/package.json
#	plugins/love-resources/src/components/ActiveInvitesPopup.svelte
#	plugins/love-resources/src/components/InvitePopup.svelte
#	plugins/love-resources/src/components/PersonActionPopup.svelte
#	plugins/love-resources/src/components/RequestPopup.svelte
#	plugins/love-resources/src/components/RequestingPopup.svelte
#	plugins/love-resources/src/components/meeting/ControlExt.svelte
#	plugins/love-resources/src/components/meeting/invites/ActiveInvitesPopup.svelte
#	plugins/love-resources/src/components/meeting/invites/InviteEmployeeButton.svelte
#	plugins/love-resources/src/components/meeting/invites/InvitePopup.svelte
#	plugins/love-resources/src/components/meeting/invites/InviteRequestPopup.svelte
#	plugins/love-resources/src/components/meeting/invites/InviteResponsePopup.svelte
#	plugins/love-resources/src/components/meeting/invites/JoinRequestPopup.svelte
#	plugins/love-resources/src/components/meeting/invites/JoinResponsePopup.svelte
#	plugins/love-resources/src/components/meeting/invites/RequestPopup.svelte
#	plugins/love-resources/src/components/meeting/invites/RequestingPopup.svelte
#	plugins/love-resources/src/meetings.ts
#	plugins/love-resources/src/utils.ts
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@utkaka utkaka requested a review from Copilot September 26, 2025 02:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the Love plugin's invite system to replace database-based join requests and invites with real-time pulse notifications. This change improves performance and reduces database load by migrating from persistent storage to ephemeral pulse-based communication.

Key changes:

  • Replaces database-persisted JoinRequest and Invite classes with pulse-based messaging
  • Migrates join request and invite handling from server triggers to client-side pulse communication
  • Consolidates pulse client functionality in the presentation package

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
server-plugins/love/src/index.ts Removes OnInvite trigger registration
server-plugins/love-resources/src/index.ts Removes database-based invite/join request handling functions and trigger exports
plugins/presence-resources/src/*.ts Updates imports to use centralized pulse client from presentation package
plugins/love/src/types.ts Removes database model definitions for JoinRequest and Invite
plugins/love/src/plugin.ts Removes class references for JoinRequest and Invite
plugins/love-resources/src/joinRequests.ts New file implementing pulse-based join request functionality
plugins/love-resources/src/invites.ts New file implementing pulse-based invite functionality
plugins/love-resources/src/meetings.ts Refactors meeting functions to use new pulse-based system
plugins/love-resources/src/components/meeting/invites/*.svelte Updates UI components to work with new pulse-based data structures
packages/presentation/src/pulse.ts Fixes import path for presentation plugin
packages/ui/src/popups.ts Fixes popup update function to properly pass props
Comments suppressed due to low confidence (1)

plugins/love-resources/src/components/meeting/invites/InviteResponsePopup.svelte:1

  • The property name invite is inconsistent with the component's export parameter which expects invite: InviteRequest. The update should use consistent naming.
<!--

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@utkaka utkaka changed the title Office pulse invites Office: use pulse for invites and join requests Sep 26, 2025
@utkaka utkaka marked this pull request as ready for review September 26, 2025 04:05
@aonnikov
Copy link
Member

Please do not merge until Monday, don't want this to get into prod yet :)

utkaka added 3 commits October 2, 2025 09:42
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>

# Conflicts:
#	plugins/love-resources/src/components/meeting/invites/InviteEmployeeButton.svelte
#	plugins/love-resources/src/utils.ts
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@aonnikov aonnikov merged commit ff4fdc2 into develop Oct 2, 2025
15 checks passed
@aonnikov aonnikov deleted the office-pulse-invites branch October 2, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants