-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update cards feed view #9979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cards feed view #9979
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Connected to Huly®: UBERF-13817 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the cards feed view to use a more sophisticated component architecture and improves the visual presentation of cards in the feed. The main purpose is to replace the direct CardFeedView component with a more flexible SpecialView component and enhance how cards are displayed with better icons, content previews, and layout improvements.
Key changes:
- Replaces direct CardFeedView usage with workbench SpecialView component for better configurability
- Introduces new UI components for enhanced card presentation including colored icons, content previews, and dividers
- Updates card presenter to show different content based on card type (thread vs non-thread cards)
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ChatApplication.svelte | Replaces CardFeedView with SpecialView component and updates imports |
TagDivider.svelte | New component providing visual divider between card elements |
NotifyMarker.svelte | New component for displaying notification markers with different sizes |
FeedCardPresenter.svelte | Major updates to card presentation logic, content display, and layout |
ContentPreview.svelte | New component for displaying card content with collapsible functionality |
ColoredCardIcon.svelte | New component for displaying themed card icons with color backgrounds |
CardPathPresenter.svelte | Updates divider usage and background color styling |
ShowMore.svelte | Adds event propagation stopping to prevent unwanted click handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
…nto cards-feed
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Before:


After: