Avoid allocating long[] holder for size = 0

headius · Aug 22, 2023 · 423a64e · 423a64e
1 parent e2c0c05
commit 423a64e
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/core/src/main/java/org/jruby/RubyHash.java b/core/src/main/java/org/jruby/RubyHash.java
@@ -1356,11 +1356,18 @@ public RubyFixnum hash() {
     @JRubyMethod(name = "hash")
     public RubyFixnum hash(ThreadContext context) {
         final int size = size();
-        long[] hval = { Helpers.hashStart(context.runtime, size) };
-        if (size > 0) {
+
+        long hash = Helpers.hashStart(context.runtime, size);
+
+        if (size != 0) {
+            long[] hval = {hash};
+
             iteratorVisitAll(context, CalculateHashVisitor, hval);
+
+            hash = hval[0];
         }
-        return context.runtime.newFixnum(hval[0]);
+
+        return context.runtime.newFixnum(hash);
     }
 
     private static final ThreadLocal<ByteBuffer> HASH_16_BYTE = ThreadLocal.withInitial(() -> ByteBuffer.allocate(16));