Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hide FilenoUtil warning behind native.verbose property
My goal with this warning was to avoid bug reports about native process functionality not working well when running without the module flags we need to dig up native file descriptors from Java channels. Since I added this, however, many things have changed: * Native process IO does not go through Java channels anymore; it instead uses real native IO all the way through. * File IO now also usually goes through JNR using a native file descriptor. * The fileno extraction is now primarily used to provide a fileno for RubyIO objects, but most Ruby code will not need the real fileno. * Module flags are frequently difficult to inject into a jar-based usage of JRuby, so these flags may not be helpful anyway. I believe a warning about degraded functionality is important, but it should be at point-of-use rather than globally just in case the native fileno functionality might become necessary in the future. As such, I am hiding this global warning behind the native.verbose property, and we can consider adding other more targeted warnings going forward.
- Loading branch information