Merge pull request jruby#8205 from enebo/fix_begin_cov

begin node coverage line should not get added if it has been removed
headius · Apr 22, 2024 · cf1935b · cf1935b
2 parents 4c961c3 + 0b09b2b
commit cf1935b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/parser/RubyParserBase.java b/core/src/main/java/org/jruby/parser/RubyParserBase.java
@@ -438,7 +438,9 @@ protected void getterIdentifierError(RubySymbol identifier) {
     public Node newline_node(Node node, int line) {
         if (node == null) return null;
 
-        node = remove_begin(node);
+        Node newNode = remove_begin(node);
+        // Conservative fix...try and use line unless we see remove has been removed then use the newNode.
+        if (newNode != node) line = newNode.getLine();
         coverLine(line);
         node.setNewline();