frontend: clusterApi: Fix testClusterHealth for multi cluster

Also fix test so it follows docs, and how the code is used.
All it cares about is if it raises an error when there is an
error condition.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>

frontend/src/lib/k8s/api/v1/apiProxy.test.ts

@@ -857,10 +857,8 @@ describe('apiProxy', () => {
       nock.cleanAll();
     });
 
-    it('Successfully checks cluster health', async () => {
-      const response = await apiProxy.testClusterHealth(clusterName);
-      const body = await response.text();
-      expect(body).toEqual('ok');
+    it('Should not raise an error on success', async () => {
+      await apiProxy.testClusterHealth(clusterName);
     });
 
     it.each([

frontend/src/lib/k8s/api/v1/clusterApi.ts

@@ -6,7 +6,7 @@ import {
   findKubeconfigByClusterName,
   storeStatelessClusterKubeconfig,
 } from '../../../../stateless';
-import { getCluster } from '../../../util';
+import { getCluster, getClusterGroup } from '../../../util';
 import { ClusterRequest, clusterRequest, post, request } from './clusterRequests';
 import { JSON_HEADERS } from './constants';
 
@@ -29,8 +29,15 @@ export async function testAuth(cluster = '', namespace = 'default') {
  * Will throw an error if the cluster is not healthy.
  */
 export async function testClusterHealth(cluster?: string) {
-  const clusterName = cluster || getCluster() || '';
-  return clusterRequest('/healthz', { isJSON: false, cluster: clusterName });
+  const clusterNames = cluster ? [cluster] : getClusterGroup();
+
+  const healthChecks = clusterNames.map(clusterName => {
+    return clusterRequest('/healthz', { isJSON: false, cluster: clusterName }).catch(error => {
+      throw new Error(`Cluster ${clusterName} is not healthy: ${error.message}`);
+    });
+  });
+
+  return Promise.all(healthChecks);
 }
 
 export async function setCluster(clusterReq: ClusterRequest) {