app: Update how we check dev mode for desktop app

We don't ship app.asar now but we were using it to check if the app is
run in dev mode or prod. This patch updates how we check dev mode.
And also includes the proper aligning for extraResources in package.json

app/electron/main.js

@@ -137,8 +137,7 @@ function startElecron() {
   const menu = Menu.buildFromTemplate(template);
   Menu.setApplicationMenu(menu);
 
-  const isDev = process.mainModule.filename.indexOf('app.asar') === -1 ||
-    process.mainModule.filename.indexOf('app') === -1;
+  const isDev = process.env.ELECTRON_DEV || false;
 
   function createWindow () {
     const startUrl = process.env.ELECTRON_START_URL || url.format({

app/package.json

@@ -10,7 +10,7 @@
     "start": "npm run copy-server-binary && cd ../ && make run-backend  & cd ../frontend/ && export BROWSER=none && npm start",
     "build": "npm run copy-server-binary && cd ../frontend/ && PUBLIC_URL='./' npm run build && cp -r ../app/electron/. build/electron",
     "package": "mkdir -p build && cp -r ../frontend/build/* ./build && electron-builder build -c.extraMetadata.main=build/electron/main.js --publish never",
-    "serve-dev": "export ELECTRON_START_URL=http://localhost:3000 && electron .",
+    "serve-dev": "export ELECTRON_DEV=1 && export ELECTRON_START_URL=http://localhost:3000 && electron .",
     "publish": "mkdir -p build && cp -r ../frontend/build/* ./build && electron-builder build -c.extraMetadata.main=build/electron/main.js --publish always"
   },
   "build": {
@@ -48,7 +48,10 @@
       "../frontend/node_modules/**/*",
       "node_modules/**/*"
     ],
-    "extraResources": ["./electron/server","./electron/server.exe"],
+    "extraResources": [
+      "./electron/server",
+      "./electron/server.exe"
+    ],
     "extraFiles": [
       {
         "from": "../frontend/build",