Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: PluginSettings: Use author for plugin origin #2572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Nov 14, 2024

This change makes the formatting of the plugin names consistent, using the plugin author for the origin value. When the author is not set, the default origin is "Unknown".

Fixes: #2544

Testing

  • Open Headlamp and navigate to the plugin settings
  • Note the consistent plugin name formats and author listed under the origin column

image
image

@skoeva skoeva added bug Something isn't working plugins labels Nov 14, 2024
@skoeva skoeva self-assigned this Nov 14, 2024
@skoeva skoeva linked an issue Nov 14, 2024 that may be closed by this pull request
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 14, 2024
@skoeva skoeva force-pushed the plugin-name-formats branch 4 times, most recently from 60f5e82 to f6598ee Compare November 15, 2024 19:09
This change makes the formatting of the plugin names consistent, using
the plugin author for the origin value. When the author is not set, the
default origin is "Unknown".

Fixes: #2544

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Plugin names have different formats
1 participant