Frontend: Add stories for chart componenets #2821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
dosubot
bot
added
the
size:XXL
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
Faakhir30
force-pushed
the
feat/new-chart-stories
branch
from
7de09b1 to
f2c2b61
Compare
Faakhir30
commented
Jan 31, 2025
| @@ -91,7 +91,7 @@ | |||
| <desc /> | |||
| <defs> | |||
| <clippath | |||
| id="recharts1-clip" | |||
| id="recharts17-clip" | |||
There was a problem hiding this comment.
Not sure though, why is this and some other places changing ID on running npm run test -- --coverage, although those components are not changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #931
Brief overview:
Charts.tsxoriginally had 4 chart components, from whichCpuCircularChartandMemoryCirclularChartcomponents had similar props, whilePodStatusCircularChartandNodeStatusCircularCharthad similar props.ResourceChartsandStatusCharts.Stories.tsxfor both.@illume PR is currently ready for review, needed your opinion weather we should have done this separation of files or not?
IMO it was too messy to deal this in single story file so refatrored a bit. Thanks !
Here's storybook video of current state:
Screencast from 2025-01-31 23-57-28.webm