upgrade jquery ckeditor and bootstrap versions (#2720)

* upgrade jquery ckeditor and bootstrap versions

* update lock files for new ckeditor version

* remove ckeditor 4.x init require

* replace src button.js with dist button.js

* replace bootstrap.min with bootstrap.bundle.min which includes correct popperjs version

* override broken modal fade in bootstrap 4

* fix cucumber

---------

Co-authored-by: Sri Harsha <sriharsha.poosa@gmail.com>

Gemfile.lock

@@ -110,7 +110,7 @@ PATH
     notifier (0.0.1)
       aasm (~> 4.8.0)
       acapi
-      ckeditor (= 4.2.4)
+      ckeditor (= 5.0.0)
       combine_pdf
       config
       curl
@@ -342,8 +342,7 @@ GEM
       coffee-rails (>= 3.2)
       railties (>= 3.0)
       sassc-rails (>= 2.1.2)
-    ckeditor (4.2.4)
-      cocaine
+    ckeditor (5.0.0)
       orm_adapter (~> 0.5.0)
     climate_control (0.2.0)
     cocaine (0.6.0)

app/assets/javascripts/application.js.erb

@@ -10,10 +10,10 @@
 // Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
 // about supported directives.
 //
-//= require jquery
+//= require jquery2
 //= require jquery-ui
 //= require jquery_ujs
-//= require bootstrap.min
+//= require bootstrap.bundle.min
 //= require bootstrap-multiselect
 //= require jquery.selectric.min
 //= require turbolinks

app/assets/javascripts/ui-components/components.js

@@ -1,7 +1,7 @@
-//= require jquery
+//= require jquery2
 //= require jquery_ujs
 //= require jquery-ui
-//= require bootstrap.min
+//= require bootstrap.bundle.min
 //= require bootstrap-treeview
 //= require jquery.selectric.min
 //= require bowser.min

app/assets/stylesheets/bootstrap_overrides.scss.erb

@@ -457,3 +457,16 @@ strong {
     }
   }
 }
+
+// Upgrading Bootstrap 3 to 4 breaks modals with top level fade class
+.modal.fade {
+  transition: opacity 0.15s linear;
+}
+
+.modal.fade.show {
+  opacity: 1;
+}
+
+.modal.fade:not(.show) {
+  opacity: 0;
+}