-
Notifications
You must be signed in to change notification settings - Fork 14
chore: apply Prettier formatting across repo #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: apply Prettier formatting across repo #114
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@pradeeban @karthiksathishjeemain As you can see in checks, Validate and Prettier Formatting checks have successfully passed. |
|
Hey @pradeeban @karthiksathishjeemain wanted to inform that my PR for fixing rest of the GitHub checks are ready and as soon as this gets reviewed, i will finish up with next ones asap. And do let me know if any changes are needed. So was doing a follow up :) |
|
Thanks, @XxSURYANSHxX for the fix. I see there are a lot of files in this commit, including many files (such as the .md) that do not appear to be relevant (or am I missing something?). If they are included mistakenly with some trivial changes (such as the change of End of Line character), can you remove them from your PR? It is important to keep the PRs minimal and free from irrelevant files to avoid merge conflicts with other pending PRs. |
|
Hey @pradeeban @karthiksathishjeemain actually what happned is that i applied the Prettier formatting across the entire repo, and in that everything was included (including .md files) as those files were already present in the repo and was not added by me. I only applied changes of Prettier formatting to it. And as you can see with my latest commit to revert all .md files to their previous state has failed the Prettier formatting check once again. and this PR is indeed very big as i asked you for your approval over here #107 (comment) . So any input on what should i do further would be really helpful. As whoever included thses checks did not test it properly and has issues in them as you stated in our conversation before. So should we remove all the .md files from the repo entirely if you do not want them ? As as far as i remember these checks and .md files were added by Amank1412. Please let me know your thoughts. Thankyou :)
|
|
@XxSURYANSHxX Ah, yes, the GenAI/LLM tools really like to create noisy/verbose md files for nothing. No one got time to read too many md files. I understand what happens here. Thanks for the explanation. Perhaps, I should simply have merged your PR as-is, without removing the md files from the PR in that case. Whether to remove the md files or their tests, we should look at it separately later. I think, although too many irrelevant md files can be an eyesore, perhaps improving/humanizing them later can have more potential than outright removing them. Perhaps, you can revert and bring the PR to include the md files too as you had before? |
|
Definitely @pradeeban Thankyou for understanding, we can do the humanisation part of the .md files after we finish the checks so that there will be no further issues. I will get right on it. |
913cf0f to
8560d3c
Compare
|
Hii @pradeeban @karthiksathishjeemain, I have successfully reverted this PR to the original commit, Please have a look and let me know your thoughts. And as you can see the preittier formatting and validation checks are green. Thankyou |
|
Merged. Thanks. |


Hi @pradeeban @karthiksathishjeemain , I was trying to fix the Prettier check that keeps failing on PRs, so I made a small “setup + cleanup” PR.
What I changed
.prettierrcat the repo root so the whole repo uses one consistent Prettier config.nextjs-frontend/.prettierrc, so we’re not inventing new formatting rules, just reusing what’s already in the repo:{
"semi": true,
"trailingComma": "es5",
"singleQuote": false,
"printWidth": 100,
"tabWidth": 2,
"useTabs": false
}
npx --yes prettier --write "**/*.{js,jsx,json,md,yaml,yml}"
So most of the diff is just formatting changes (spacing / line breaks / quotes), and the only real “new” thing is the root
.prettierrc.Why I did it
The CI already runs a Prettier check (
prettier --check "**/*.{js,jsx,json,md,yaml,yml}").But without a shared config at the repo root, formatting can be inconsistent between folders, and PRs fail just because of style. This should make future PRs simpler: as long as Prettier runs (or the editor formats on save), the Prettier check should stay green.
(Also, this PR doesn’t fix the other CI failures yet — it’s only to make the Prettier check consistent.) Please have a look and let me know your thoughts. Thankyou.