Fix maybe-uninitialized warning in IsSpentKey

hebasto · Aug 21, 2024 · 17707db · 17707db
1 parent bc87ad9
commit 17707db
Showing 1 changed file with 14 additions and 15 deletions.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -1039,21 +1039,20 @@ bool CWallet::IsSpentKey(const CScript& scriptPubKey) const
         return true;
     }
 
-    LegacyScriptPubKeyMan* spk_man = GetLegacyScriptPubKeyMan();
-    if (!spk_man) return false;
-
-    for (const auto& keyid : GetAffectedKeys(scriptPubKey, *spk_man)) {
-        WitnessV0KeyHash wpkh_dest(keyid);
-        if (IsAddressPreviouslySpent(wpkh_dest)) {
-            return true;
-        }
-        ScriptHash sh_wpkh_dest(GetScriptForDestination(wpkh_dest));
-        if (IsAddressPreviouslySpent(sh_wpkh_dest)) {
-            return true;
-        }
-        PKHash pkh_dest(keyid);
-        if (IsAddressPreviouslySpent(pkh_dest)) {
-            return true;
+    if (LegacyScriptPubKeyMan* spk_man = GetLegacyScriptPubKeyMan()) {
+        for (const auto& keyid : GetAffectedKeys(scriptPubKey, *spk_man)) {
+            WitnessV0KeyHash wpkh_dest(keyid);
+            if (IsAddressPreviouslySpent(wpkh_dest)) {
+                return true;
+            }
+            ScriptHash sh_wpkh_dest(GetScriptForDestination(wpkh_dest));
+            if (IsAddressPreviouslySpent(sh_wpkh_dest)) {
+                return true;
+            }
+            PKHash pkh_dest(keyid);
+            if (IsAddressPreviouslySpent(pkh_dest)) {
+                return true;
+            }
         }
     }
     return false;