Skip to content

Commit

Permalink
Merge bitcoin#30734: doc: fix a few likely documentation typos relate…
Browse files Browse the repository at this point in the history
…d to CMake migration

7ee5c3c Fix a few likely documentation typos (Lőrinc)

Pull request description:

  Found them during CMake migration - and ran a quick spellcheck for the rest to cover any remaining ones

ACKs for top commit:
  maflcko:
    lgtm ACK 7ee5c3c

Tree-SHA512: c6e7aa1e952e0d093745c4e6004c3907b7a215c6f998cc205307c0c68abcc067bf3f56e22af0deb1710186e8a871306f4bae8a35c74581e5299abcbbcddfaa75
  • Loading branch information
fanquake committed Aug 28, 2024
2 parents d184fc3 + 7ee5c3c commit 4ee1940
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion doc/build-windows-msvc.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ cmake --list-presets

CMake will put the resulting object files, libraries, and executables into a dedicated build directory.

In following istructions, the "Debug" configuration can be specified instead of the "Release" one.
In the following instructions, the "Debug" configuration can be specified instead of the "Release" one.

### 4. Building with Dynamic Linking with GUI

Expand Down
10 changes: 5 additions & 5 deletions src/test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ during the generation of the Bitcoin Core build system
and tests weren't explicitly disabled.

Assuming the build directory is named `build`, the unit tests can be run
with `ctests --test-dir build`, which includes unit tests from subtrees.
with `ctest --test-dir build`, which includes unit tests from subtrees.

To run the unit tests manually, launch `build/src/test/test_bitcoin`. To recompile
after a test file was modified, run `cmake --build build` and then run the test again. If you
Expand Down Expand Up @@ -83,7 +83,7 @@ so no leftover state is used.)

```bash
$ build/src/test/test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir"
Running 1 test case...

*** No errors detected
Expand Down Expand Up @@ -112,8 +112,8 @@ see `uint256_tests.cpp`.

### Logging and debugging in unit tests

`ctest --test-dir build` will write to a log file `build/Testing/Temporary/LastTest.log`. You can
additionaly use the `--output-on-failure` option to display logs of the failed tests automatically
`ctest --test-dir build` will write to the log file `build/Testing/Temporary/LastTest.log`. You can
additionally use the `--output-on-failure` option to display logs of the failed tests automatically
on failure. For running individual tests verbosely, refer to the section
[above](#running-individual-tests).

Expand Down Expand Up @@ -150,5 +150,5 @@ You can then explore the core dump using
```bash
gdb build/src/test/test_bitcoin core

(gbd) bt # produce a backtrace for where a segfault occurred
(gdb) bt # produce a backtrace for where a segfault occurred
```

0 comments on commit 4ee1940

Please sign in to comment.