Skip to content

Commit

Permalink
Merge #120: cmake, ci: Ccache improving in macOS jobs
Browse files Browse the repository at this point in the history
326d0f7 fixup! ci: Test CMake edge cases (Hennadii Stepanov)

Pull request description:

  For the recent two consequential CI runs:
  - https://github.com/hebasto/bitcoin/actions/runs/8263699604 and
  - https://github.com/hebasto/bitcoin/actions/runs/8264179478

  I've noticed a [pure Ccache performance](https://github.com/hebasto/bitcoin/actions/runs/8264179478/job/22607226576) for the "macOS 13 native, x86_64, Xcode 14.3" job:
  ```
  Cacheable calls:     634 / 634 (100.0%)
    Hits:                0 / 634 ( 0.00%)
  ```

  This PR sets `CCACHE_COMPILERCHECK=%compiler% -v` for macOS jobs to avoid false cache invalidating.

  The other option, i.e., `content`, has been tried as well in my experiments, but it also has cache performance issues.

ACKs for top commit:
  pablomartin4btc:
    utACK 326d0f7

Tree-SHA512: 2c01dca0699b788341de0bd7436a6c6664dce189e3604b894d5ebe60d0267d49911949c3ee2eb8b3095b03a94773830a4840dfb3592628c55314009dd39170e8
  • Loading branch information
hebasto committed Mar 17, 2024
2 parents 5e65a38 + 326d0f7 commit 822c3fc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ jobs:
${{ matrix.xcode.configure_env }} cmake -B build -DWERROR=ON
- name: Build
env:
CCACHE_COMPILERCHECK: '%compiler% -v'
run: |
ccache --zero-stats
cmake --build build -j $(sysctl -n hw.logicalcpu)
Expand Down

0 comments on commit 822c3fc

Please sign in to comment.