Merge #332: cmake: Maintain build-time dependencies for the `check-sy…

…mbols` and `check-security` targets

943b0ca fixup! cmake: Add `Maintenance` module (Hennadii Stepanov)

Pull request description:

  It was noted offline:
  > I don’t really see why targets, which have dependencies, should, rather than adding those dependencies, instead rely on running the right commands in the right order. That seems like fragile design?

  This PR fixes this issue.

Top commit has no ACKs.

Tree-SHA512: 072af89eeb13524eb9172e84baf5ae8008a74ae1ca5a972e31a1fdef7f6a8b83a355f3cdc9753008b7433d20e477b751d831296768d7207d1f84fb6548471507

cmake/module/Maintenance.cmake

@@ -44,9 +44,7 @@ function(add_maintenance_targets)
 
   foreach(target IN ITEMS bitcoind bitcoin-qt bitcoin-cli bitcoin-tx bitcoin-util bitcoin-wallet test_bitcoin bench_bitcoin)
     if(TARGET ${target})
-      # Not using the TARGET_FILE generator expression because it creates excessive
-      # target-level dependencies in the following custom targets.
-      list(APPEND executables $<TARGET_FILE_DIR:${target}>/$<TARGET_FILE_NAME:${target}>)
+      list(APPEND executables $<TARGET_FILE:${target}>)
     endif()
   endforeach()