[FIXUP] cmake: Do not trigger cross-compiling unnecessarily

CMakeLists.txt

@@ -483,7 +483,7 @@ else()
   )
 endif()
 
-if(CMAKE_CROSSCOMPILING)
+if(BITCOIN_BUILD_WITH_DEPENDS)
   target_compile_definitions(core_base_interface INTERFACE ${DEPENDS_COMPILE_DEFINITIONS})
   target_compile_definitions(core_depends_release_interface INTERFACE ${DEPENDS_COMPILE_DEFINITIONS_RELWITHDEBINFO})
   target_compile_definitions(core_depends_debug_interface INTERFACE ${DEPENDS_COMPILE_DEFINITIONS_DEBUG})

cmake/module/CrossPkgConfig.cmake

@@ -5,7 +5,7 @@
 find_package(PkgConfig REQUIRED)
 
 macro(cross_pkg_check_modules prefix)
-  if(CMAKE_CROSSCOMPILING)
+  if(BITCOIN_BUILD_WITH_DEPENDS)
     set(pkg_config_path_saved "$ENV{PKG_CONFIG_PATH}")
     set(pkg_config_libdir_saved "$ENV{PKG_CONFIG_LIBDIR}")
     set(ENV{PKG_CONFIG_PATH} ${PKG_CONFIG_PATH})

cmake/module/Maintenance.cmake

@@ -30,7 +30,7 @@ function(add_maintenance_targets)
   else()
     set(exe_format ELF)
   endif()
-  if(CMAKE_CROSSCOMPILING)
+  if(BITCOIN_BUILD_WITH_DEPENDS)
     list(JOIN DEPENDS_C_COMPILER_WITH_LAUNCHER " " c_compiler_command)
   else()
     set(c_compiler_command ${CMAKE_C_COMPILER})

depends/Makefile

@@ -259,9 +259,16 @@ $(host_prefix)/share/config.site : config.site.in $(host_prefix)/.stamp_$(final_
             $< > $@
 	touch $@
 
+ifeq ($(host),$(build))
+  crosscompiling=FALSE
+else
+  crosscompiling=TRUE
+endif
+
 $(host_prefix)/share/toolchain.cmake : toolchain.cmake.in $(host_prefix)/.stamp_$(final_build_id)
 	@mkdir -p $(@D)
-	sed -e 's|@host_system@|$($(host_os)_cmake_system)|' \
+	sed -e 's|@depends_crosscompiling@|$(crosscompiling)|' \
+            -e 's|@host_system@|$($(host_os)_cmake_system)|' \
             -e 's|@host_arch@|$(host_arch)|' \
             -e 's|@CC@|$(host_CC)|' \
             -e 's|@CXX@|$(host_CXX)|' \

depends/toolchain.cmake.in

@@ -4,8 +4,13 @@
 
 # This file is expected to be highly volatile and may still change substantially.
 
-set(CMAKE_SYSTEM_NAME @host_system@)
-set(CMAKE_SYSTEM_PROCESSOR @host_arch@)
+set(BITCOIN_BUILD_WITH_DEPENDS TRUE)
+
+set(DEPENDS_CROSSCOMPILING @depends_crosscompiling@)
+if(DEPENDS_CROSSCOMPILING)
+  set(CMAKE_SYSTEM_NAME @host_system@)
+  set(CMAKE_SYSTEM_PROCESSOR @host_arch@)
+endif()
 
 function(split_compiler_launcher env_compiler launcher compiler)
   set(${launcher})

src/qt/CMakeLists.txt

@@ -35,7 +35,7 @@ if(BUILD_GUI_TESTS)
   list(APPEND qt_components Test)
 endif()
 
-if(CMAKE_CROSSCOMPILING)
+if(BITCOIN_BUILD_WITH_DEPENDS)
   # The find_package(Qt ...) function internally uses find_library()
   # calls for all dependencies to ensure their availability.
   # In turn, the find_library() inspects the well-known locations