Skip to content

Commit

Permalink
Merge bitcoin#30502: doc: add release notes for bitcoin#22729
Browse files Browse the repository at this point in the history
6d33e13 doc: tor.md: use -bind=127.0.0.1:8334=onion for the Tor bind (David Gumberg)
a7f5d18 doc: add release notes for bitcoin#22729 (Vasil Dimov)

Pull request description:

  Add release notes for bitcoin#22729.

ACKs for top commit:
  davidgumberg:
    reACK bitcoin@6d33e13
  willcl-ark:
    ACK 6d33e13

Tree-SHA512: 9d7e66ee1d0bb1d75b8273707d30f20915d5040a768c2c5cd47c84997df2645c8bec35db6c09dc77ab917836622411b924373816cbc83c4be38e2e9156a139d8
  • Loading branch information
glozow committed Aug 5, 2024
2 parents 1a19a4d + 6d33e13 commit f0d0855
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
21 changes: 21 additions & 0 deletions doc/release-notes-22729.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
Notable changes
===============

P2P and network changes
-----------------------

- Previously if Bitcoin Core was listening for P2P connections, either using
default settings or via `bind=addr:port` it would always also bind to
`127.0.0.1:8334` to listen for Tor connections. It was not possible to switch
this off, even if the node didn't use Tor. This has been changed and now
`bind=addr:port` results in binding on `addr:port` only. The default behavior
of binding to `0.0.0.0:8333` and `127.0.0.1:8334` has not been changed.

If you are using a `bind=...` configuration without `bind=...=onion` and rely
on the previous implied behavior to accept incoming Tor connections at
`127.0.0.1:8334`, you need to now make this explicit by using
`bind=... bind=127.0.0.1:8334=onion`. (#22729)

- Bitcoin Core will now fail to start up if any of its P2P binds fail, rather
than the previous behaviour where it would only abort startup if all P2P
binds had failed. (#22729)
2 changes: 1 addition & 1 deletion doc/tor.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ In a typical situation, where you're only reachable via Tor, this should suffice
listen on all devices and another node could establish a clearnet connection, when knowing
your address. To mitigate this, additionally bind the address of your Tor proxy:

./bitcoind ... -bind=127.0.0.1
./bitcoind ... -bind=127.0.0.1:8334=onion

If you don't care too much about hiding your node, and want to be reachable on IPv4
as well, use `discover` instead:
Expand Down

0 comments on commit f0d0855

Please sign in to comment.