cmake: Regular rebasing of the cmake-staging branch
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a sanity check for non-encapsulated (directory-wide) build properties.
Co-authored-by: Cory Fields <cory-nospam-@coryfields.com> Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
|
Friendly ping @m3dwards @TheCharlatan @pablomartin4btc @vasild :) |
|
My Guix build: |
If any of {C,CXX,CPP,LD}FLAGS is specified it should be assigned to
a non-type-specific variable.
To configure CMake for cross-compiling, use
`--toolchain depends/${HOST}/share/toolchain.cmake` command-line option.
This reverts commit 1155978.
Our `QT_STATICPLUGIN` macro is effectively equivalent to the Qt's `QT_STATIC` macro. No need to handle both of them.
When using CMake, each plugin comes with a C++ stub file that automatically initializes the static plugin. Consequently, any target that links against a plugin has this C++ file added to its SOURCES, which makes the removed code redundant.
Only versioning has been updated for now.
Keep this commit at the top when rebasing.
I've incorporated the recent merged PRs: Ready for the final review :) |
|
lgtm, |
TheCharlatan
approved these changes
Mar 26, 2024
|
Thank you for your review! This branch has been force pushed into the https://github.com/hebasto/bitcoin/tree/cmake-staging. Closing. |
Done in #132. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cmake-staging branch rebased on the recent bitcoin/master one with the squashed "!fixup" and "FIXUP:" commits.
Steps to reproduce:
There are a few conflicts that have to be resolved.
At this point the diff between
HEADand this PR branch must coincides with changes in the following item 4.Manually move changes from "FIXUP:" commits to the appropriate previous ones.
Reorder the recent commits to pop up the CI one.
Backport changes from:
Changes from bitcoin#27375 are to be backported in the dedicated PR shortly after approving this one.
If it happens that #82 will be approved first (fingers crossed 🤞), I'll be happy to update this PR accordingly.Incorporated :)