cmake: Disable EXPORT_COMPILE_COMMANDS for all subtree targets
#206
Conversation
|
See the recent push to bitcoin#29790 for the CI logs. |
There was a problem hiding this comment.
Hmm, leaning towards concept NACK I think.
I guess the idea here is to set/restore the global around the subtree includes rather than setting the property per-lib?
I think I'd rather be explicit, even if there's a small risk of forgetting to set it, we'd notice eventually.
Disable `EXPORT_COMPILE_COMMANDS` for `crc32c` subtree targets
Disable `EXPORT_COMPILE_COMMANDS` for `secp256k1` subtree targets
Thanks! Reworked. |
| @@ -57,3 +57,4 @@ if(MSVC) | |||
| endif() | |||
|
|
|||
| target_link_libraries(secp256k1 PRIVATE core_base_interface) | |||
| set_target_properties(secp256k1 PROPERTIES EXPORT_COMPILE_COMMANDS OFF) | |||
There was a problem hiding this comment.
What will happen here when we switch to using secp's CMake build?
There was a problem hiding this comment.
What will happen here when we switch to using secp's CMake build?
I can see two options.
- We keep setting the target property externally as we currently do.
Or
- Upstream secp build system can force this property disabled when being a subproject.
Fixes the second point from bitcoin#29790 (comment):