-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake, doc: Update build-unix.md
#208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablomartin4btc's #208 (comment) has been addressed. |
re-ACK a11cb27 |
@@ -134,7 +133,7 @@ GUI dependencies: | |||
|
|||
If you want to build bitcoin-qt, make sure that the required packages for Qt development | |||
are installed. Qt 5 is necessary to build the GUI. | |||
To build without GUI pass `--without-gui`. | |||
To build with GUI pass `-DBUILD_GUI=ON`. | |||
|
|||
To build with Qt 5 you need the following: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Once these are installed, they will be found by configure and a bitcoin-qt executable will be
built by default."
This is no longer true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this being the case, shouldn't we delete the line: "Once these are installed, they will be found by configure and a bitcoin-qt executable will be built by default."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Deleted.
Added some nits, two unrelated to the change to cmake. |
@m3dwards's #208 (comment) has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just left some comments.
./configure | ||
make # use "-j N" for N parallel jobs | ||
make install # optional | ||
cmake -B build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked previously about adding -S
to the docs whenever we are configuring, but I can't remember anymore what the verdict was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. There was -S
in the past. See:
We agreed to use modern CMake invocation style. Configuring in the source root makes the -S
option redundant.
No description provided.