Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix configuration for Illumos/SmartOS. #228

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jun 11, 2024

This PR fixes a buggy implementation of the getifaddrs/freeifaddrs symbols checking in the ifaddrs.h header.

On illumos/SunOS:

  • on the master branch:
$ cmake -B build
<snip>
-- Looking for freeifaddrs
-- Looking for freeifaddrs - not found
-- Looking for getifaddrs
-- Looking for getifaddrs - not found
<snip>
  • with this PR:
$ cmake -B build
<snip>
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include ifaddrs.h
-- Looking for C++ include ifaddrs.h - found
-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET
-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET - Failed
-- Performing Test IFADDR_NEEDS_LINK_TO_LIBSOCKET
-- Performing Test IFADDR_NEEDS_LINK_TO_LIBSOCKET - Success
<snip>

Fix configuration for Illumos/SmartOS.
@hebasto hebasto added the bug Something isn't working label Jun 11, 2024
@hebasto hebasto added this to the Ready for master milestone Jun 18, 2024
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Seems closer to what we are doing in autotools and seems to only set the symbols if the check has passed now.

@hebasto hebasto merged commit 93667ed into cmake-staging Jun 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants