Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Implement translate target #232

Merged
merged 2 commits into from
Jun 19, 2024
Merged

cmake: Implement translate target #232

merged 2 commits into from
Jun 19, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jun 18, 2024

The suggested steps to test:

  1. Run Autotools' make translate:
$ ./autogen.sh && ./configure --with-incompatible-bdb
$ make -C src translate
  1. Commit changes.
  2. Then build CMake's translate target:
$ cmake -B build -DBUILD_GUI=ON -DWITH_BDB=ON
$ cmake --build build -t translate

No new changes must be introduced.

@hebasto
fixup! cmake: Build bitcoin-qt executable
4946be6 
Add headers to GUI sources as they need to be parsed to collect
translatable strings.
@hebasto
cmake: Implement translate target
63972bb
@hebasto hebasto added this to the Ready for master milestone Jun 18, 2024
@hebasto hebasto added the enhancement New feature or request label Jun 18, 2024
@m3dwards
Copy link

ACK 63972bb

Found 1235 source text(s) (0 new and 1235 already existing)

@hebasto hebasto merged commit 4778d28 into cmake-staging Jun 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Ready for master
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @m3dwards