Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXUP] cmake: Improve description and document APPEND_*FLAGS #244

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[FIXUP] cmake: Improve description and document APPEND_*FLAGS #244

merged 1 commit into from
Jun 27, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jun 27, 2024

Descriptions and the comment have been aligned with bitcoin-core/secp256k1#1546.

Closes #239.

@hebasto
Copy link
Owner Author

hebasto commented Jun 27, 2024

cc @real-or-random

@hebasto hebasto mentioned this pull request Jun 27, 2024
Closed
@hebasto hebasto added the documentation Docs and manuals label Jun 27, 2024
@hebasto hebasto added this to the Ready for master milestone Jun 27, 2024
real-or-random
real-or-random approved these changes Jun 27, 2024
View reviewed changes
Copy link

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9a5f39f

@hebasto hebasto merged commit 119b07e into cmake-staging Jun 27, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
documentation Docs and manuals
Projects
None yet
Milestone
Ready for master
Development

Successfully merging this pull request may close these issues.

Bad practice to set rule variables?
2 participants
@hebasto @real-or-random