[FIXUP] cmake: Enable CMP0141 policy after cmake_minimum_required()
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the policy setting won't get any effect.
|
ACK af5e6b4 Slight adjustment needed for me to print result variable: cmake_policy(GET CMP0141 result)
message("${result}") |
Sure! Thank you. A typo has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the policy setting won't get any effect.
See https://cmake.org/cmake/help/latest/policy/CMP0141.html
After #215, the
CMAKE_MSVC_DEBUG_INFORMATION_FORMATCMake's abstraction is not used in our code directly, but it is still convenient for the user to be able to use it when configuring the build system from the command line or an IDE.This change can be easily verified on any system (not Windows only) by injecting the following commands: