Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Fix build with -DENABLE_HARDENING=OFF #248

Merged
merged 1 commit into from
Jul 1, 2024
Merged

cmake: Fix build with -DENABLE_HARDENING=OFF #248

merged 1 commit into from
Jul 1, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jun 30, 2024

On the staging branch @ a7cc7d8:

$ cmake -B build -DENABLE_HARDENING=OFF
$ cmake --build build
...
/usr/bin/ld: cannot find -lhardening_interface: No such file or directory
...

This PR fixes this issue.

@hebasto hebasto added the bug Something isn't working label Jun 30, 2024
@hebasto hebasto added this to the Ready for master milestone Jun 30, 2024
TheCharlatan
TheCharlatan approved these changes Jul 1, 2024
View reviewed changes
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK 0537ae7

@hebasto hebasto merged commit 9794bdd into cmake-staging Jul 1, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Ready for master
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @TheCharlatan