-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Revert CMake's way to handle definitions #269
Conversation
Friendly ping @maflcko @theuni @fanquake @TheCharlatan :) |
Are these going to remain as reverts on top of the original changes? |
No. I'm going to squash these commits with the past relevant commits during the next sync/rebase round. |
Rebased on top of the merged #268. |
…ET_PEER_CONST_CHAR`
This change minimizes the diff for the `bitcoin-config.h` files generated by Autotools vs CMake.
The commit messages have been updated to reflect this intention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is correct. Hard to tell without doing a full rebase, but the only related code-change in the diff from pre-cmake is src/qt/guiutil.cpp, which had its bitcoin-config.h include removed for the static plugin change.
If there are any mistakes here, I think they'll be obvious post-rebase.
utACK f440d33
This PR adjusts CMake scripts in such a way that makes removing
#include <config/bitcoin-config.h>
from sources is unnecessary.Effectively, this makes Autotools and CMake builds comparable.
Addresses bitcoin#30454 (comment) and bitcoin#30454 (comment).