Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake, ci: Consistently put all CPPFLAGS into -DAPPEND_CPPFLAGS #273

Merged
merged 1 commit into from
Jul 24, 2024
Merged

cmake, ci: Consistently put all CPPFLAGS into -DAPPEND_CPPFLAGS #273

merged 1 commit into from
Jul 24, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 20, 2024 •
edited
Loading

This PR addresses this bitcoin#30454 (comment):

CPP flag handling seems inconsistent throughout the CI changes, which is confusing. It'd be good to consistently put all CPPFLAGS into CPPFLAGS, rather than having them sometimes in CXXFLAGS, sometimes in (append) CPPFLAGS, and sometimes spread between the two, i.e here.

The CI logs are available here: https://cirrus-ci.com/build/5765939633848320

This was referenced Jul 20, 2024
Merged
Closed
@hebasto
Copy link
Owner Author

hebasto commented Jul 20, 2024

cc @fanquake

TheCharlatan
TheCharlatan approved these changes Jul 23, 2024
View reviewed changes
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Nit: I'd find it a bit more readable if each of the variables were on their own line.

@hebasto
Copy link
Owner Author

hebasto commented Jul 23, 2024

@TheCharlatan

lgtm

Nit: I'd find it a bit more readable if each of the variables were on their own line.

Updated per your nit. Does it look better now?

@hebasto
Copy link
Owner Author

hebasto commented Jul 23, 2024

The CI logs for the recent changes are available here: https://cirrus-ci.com/build/5863226292830208.

TheCharlatan
TheCharlatan approved these changes Jul 24, 2024
View reviewed changes
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit 6d23915 into cmake-staging Jul 24, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @TheCharlatan