Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Minimize diff between staging branch and main repo PR #274

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 20, 2024

As noted in bitcoin#30454 (comment):

The only differences from the staging branch are:
...
2. This PR skips the removal of the legacy MSVC build system. The goal is to delete it simultaneously with the Autotools-based build system later.
...

This PR removes this difference to make comparing these two branches trivial.

The last commit does not affect the bitcoin#30454. It just removes no longer needed change.

@hebasto
Copy link
Owner Author

hebasto commented Jul 22, 2024

The last commit does not affect the bitcoin#30454. It just removes no longer needed change.

Dropped this commit. See bitcoin#30151 (comment)

Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit 77da79f into cmake-staging Jul 23, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants