Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Port PR30519 from the master branch #281

Merged
merged 2 commits into from
Jul 25, 2024
Merged

cmake: Port PR30519 from the master branch #281

merged 2 commits into from
Jul 25, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 25, 2024

This PR ports bitcoin#30519.

@fanquake @hebasto
refactor: fix missing includes
3de63c7 
These cause compile failures with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES.
i.e:
```bash
In file included from init.cpp:8:
./init.h:46:54: error: no template named 'atomic' in namespace 'std'
   46 | bool AppInitBasicSetup(const ArgsManager& args, std::atomic<int>& exit_status);
      |                                                 ~~~~~^
1 error generated.
```

See: https://libcxx.llvm.org/DesignDocs/HeaderRemovalPolicy.html.
@fanquake @hebasto
fixup! ci: Migrate CI scripts to CMake
c814a1c 
Port PR30519.
@hebasto hebasto added the port from autotools Ported from the main repository label Jul 25, 2024
@hebasto
Copy link
Owner Author

hebasto commented Jul 25, 2024

cc @fanquake @maflcko

@hebasto hebasto mentioned this pull request Jul 25, 2024
Merged
@hebasto hebasto merged commit 52829c3 into cmake-staging Jul 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko approved these changes

Assignees
No one assigned
Labels
port from autotools Ported from the main repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @maflcko @fanquake