Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake, doc: Avoid unnecessarily breaking external links to doc/build-windows.md #284

Merged
merged 1 commit into from
Jul 26, 2024
Merged

cmake, doc: Avoid unnecessarily breaking external links to doc/build-windows.md #284

merged 1 commit into from
Jul 26, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 25, 2024

Other projects may use external links to our documentation. Therefore, avoid breaking them unnecessarily.

@hebasto
Copy link
Owner Author

hebasto commented Jul 25, 2024

cc @TheCharlatan, who pointed at the issue during today's CMake-WG call.

This was referenced Jul 25, 2024
Closed
Merged
maflcko
maflcko reviewed Jul 25, 2024
View reviewed changes
Copy link

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, given that the docs link to each other

But the diff doesn't look right.

doc/build-windows.md Outdated Show resolved Hide resolved
@hebasto
fixup! doc: Update for CMake-based build system
b6baa47 
Avoid unnecessarily breaking external links to `doc/build-windows.md`.
@hebasto
Copy link
Owner Author

hebasto commented Jul 25, 2024

But the diff doesn't look right.

Thanks! Fixed.

maflcko
maflcko approved these changes Jul 25, 2024
View reviewed changes
Copy link

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto added the documentation Docs and manuals label Jul 25, 2024
@hebasto hebasto merged commit 9256718 into cmake-staging Jul 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko approved these changes

Assignees
No one assigned
Labels
documentation Docs and manuals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hebasto @maflcko