-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Fix toolchain.cmake
for *BSD systems
#292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 20ef783
... because these package are not available for the host systems ...
Why? FreeBSD has packages for qt and qrencode.
I did not mean the package availabilty via the system package manager, but rather how our depends build sub-system is configured. |
Testing instructions have been added to the PR description per your request. |
I tested this on FreeBSD: on
and succeeds with the changes from this branch. Unrelated to this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-merge ACK 20ef783, tested on OpenBSD 7.5
(note that I had to cherry-pick the zeromq
build fix for OpenBSD [bitcoin#30565, 89b1d5c] first, as it's seemingly not in the cmake staging branch yet)
For *BSD systems, the
qt
andqrencode
packages are not built, even without theNO_QT
orNO_QR
variables defined, because these package are not available for the host systems:bitcoin/depends/packages/packages.mk
Lines 7 to 13 in 19d4d92
We already handle the exact logic for the
systemtap
(USDT) package. Therefore, it is reasonable to use this working logic uniformly for all cases.Additionally, this PR correctly handles cases when a
*_packages_
variable contains only spaces rather than being empty.How to test this PR on a *BSD system:
depends/README.md
,doc/build-*bsd.md
)It fails.
With this PR it configures successfully.