cmake: Fix AddBoostIfNeeded module
#312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you elaborate. Why does it fail (what failure?) on some systems? |
Here is an excerpt from |
Pass `-DBOOST_NO_CXX98_FUNCTION_BASE` to the header check only when applicable. We have to pass it if accepted; otherwise, the test header check may fail on some systems, such as macOS arm64 + Homebrew's boost@1.76.
hebasto
force-pushed
the
240807-cmake-IK
branch
from
589aba9
to
dcdf37a
Compare
|
Rebased. |
TheCharlatan
approved these changes
Aug 13, 2024
|
@TheCharlatan if you do a build with cmake-staging (ad73445) on macOS with -- Found Boost: /opt/homebrew/include (found suitable version "1.85.0", minimum required is "1.73.0")
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE - Failed
-- Looking for C++ include boost/test/included/unit_test.hpp
-- Looking for C++ include boost/test/included/unit_test.hpp - not found
CMake Error at cmake/module/AddBoostIfNeeded.cmake:72 (message):
Building test_bitcoin executable requested but
boost/test/included/unit_test.hpp header not available.
Call Stack (most recent call first):
CMakeLists.txt:410 (add_boost_if_needed) |
Ah, thanks, I see the failure now on macos and it passing with this patch. |
|
Warnings from system headers are suppressed by both clang and gcc. That is, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-posted from bitcoin#30454 (comment):
This PR addresses the first part (see the commit message for more details).
The second one remains unaddressed for the following reasons:
-DWERROR=ON(or--enable-debugin Autotools) was never used to control passing the-Werrorflag to checks of any type.-Werrorin check for header availability. It is not clear whyunit_test.hppshould be an exception.Please correct me if my understanding is wrong.