Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: A couple of typo fixes #331

Closed

Conversation

TheCharlatan
Copy link

Just a couple of typo fixes.

@@ -65,7 +65,7 @@ function(add_boost_if_needed)
endif()

if(BUILD_TESTS)
# Some package managers, such as vcpkg, vendor Boost.Test separately
# Some package managers, such as vcpkg, vendor Boost. Test separately
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a typo :)

It refers to the "Boost.Test" module.

@@ -365,7 +365,7 @@ target_link_libraries(core_interface INTERFACE sanitize_interface)
if(SANITIZERS)
# First check if the compiler accepts flags. If an incompatible pair like
# -fsanitize=address,thread is used here, this check will fail. This will also
# fail if a bad argument is passed, e.g. -fsanitize=undfeined
# fail if a bad argument is passed, e.g. -fsanitize=undefined
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a typo, rather an example of literally bad argument.

Compare:

bitcoin/configure.ac

Lines 351 to 353 in 3c200d5

dnl First check if the compiler accepts flags. If an incompatible pair like
dnl -fsanitize=address,thread is used here, this check will fail. This will also
dnl fail if a bad argument is passed, e.g. -fsanitize=undfeined

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I need to take a break!

@TheCharlatan TheCharlatan deleted the fix-fuzz-doc-typo branch August 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants