-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: A couple of typo fixes #331
docs: A couple of typo fixes #331
Conversation
@@ -65,7 +65,7 @@ function(add_boost_if_needed) | |||
endif() | |||
|
|||
if(BUILD_TESTS) | |||
# Some package managers, such as vcpkg, vendor Boost.Test separately | |||
# Some package managers, such as vcpkg, vendor Boost. Test separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a typo :)
It refers to the "Boost.Test" module.
@@ -365,7 +365,7 @@ target_link_libraries(core_interface INTERFACE sanitize_interface) | |||
if(SANITIZERS) | |||
# First check if the compiler accepts flags. If an incompatible pair like | |||
# -fsanitize=address,thread is used here, this check will fail. This will also | |||
# fail if a bad argument is passed, e.g. -fsanitize=undfeined | |||
# fail if a bad argument is passed, e.g. -fsanitize=undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a typo, rather an example of literally bad argument.
Compare:
Lines 351 to 353 in 3c200d5
dnl First check if the compiler accepts flags. If an incompatible pair like | |
dnl -fsanitize=address,thread is used here, this check will fail. This will also | |
dnl fail if a bad argument is passed, e.g. -fsanitize=undfeined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I need to take a break!
Just a couple of typo fixes.