Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Bug fixes #87

Merged
merged 2 commits into from
Jan 29, 2024
Merged

cmake: Bug fixes #87

merged 2 commits into from
Jan 29, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jan 27, 2024

From #85 (comment):

Known Bugs

Unfortunately, due to a silent conflict between #43 and #77, providing -DFUZZ=ON does not disable the bitcoin-qt target. It will be fixed shortly after pushing this branch.

Fixed.

@hebasto hebasto added the bug Something isn't working label Jan 27, 2024
@TheCharlatan
Copy link

What is the first commit for?

@hebasto
Copy link
Owner Author

hebasto commented Jan 28, 2024

What is the first commit for?

During the last sync an empty ci.yml file was left instead of removing it. It was a rebasing mistake. Now this file causes irrelevant noise in the CI logs.

vasild
vasild approved these changes Jan 29, 2024
View reviewed changes
Copy link

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 63c1bb5

@hebasto hebasto merged commit 1f41cc3 into cmake-staging Jan 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasild vasild vasild approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @TheCharlatan @vasild