Fix bug with tag group equivalence that was causing tests to fail

Also delete semicolon from commented-out auxiliary spec file line.
hed-standard · Sep 13, 2024 · c68bdd6 · c68bdd6
1 parent db0b4ae
commit c68bdd6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/parser/parsedHedGroup.js b/parser/parsedHedGroup.js
@@ -451,7 +451,11 @@ export class ParsedHedGroup extends ParsedHedSubstring {
     if (!(other instanceof ParsedHedGroup)) {
       return false
     }
-    return differenceWith(this.tags, other.tags, (ours, theirs) => ours.equivalent(theirs)).length === 0
+    const equivalence = (ours, theirs) => ours.equivalent(theirs)
+    return (
+      differenceWith(this.tags, other.tags, equivalence).length === 0 &&
+      differenceWith(other.tags, this.tags, equivalence).length === 0
+    )
   }
 
   /**

diff --git a/spec_tests/jsonTests.spec.js b/spec_tests/jsonTests.spec.js
@@ -21,7 +21,7 @@ const skippedErrors = {
 }
 const readFileSync = fs.readFileSync
 const test_file_name = 'javascript_tests.json'
-//const test_file_name = 'temp3.json';
+//const test_file_name = 'temp3.json'
 
 function comboListToStrings(items) {
   const comboItems = []