Fix duplicate tag check #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happy5214
added
bug
VisLab
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the duplicate tag check. There were two issues. First, the subgroup array iterator in
ParsedTagGroupwas only returning the tags, excluding any groups. Also, only the top-level tags (not groups) were checked. Both were fixed, and the ensuing issue with the unique tag check was also mitigated. The JSON spec tests for duplicate tags were ported to the main JavaScript testcases for verification.In order to make the sidecar tests pass, tag level validation (duplicate and unique tags) were moved up to string-level validation.