Skip to content

Update tokenizer to handle (, x #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Nov 4, 2024

Slightly refactored comma handling to handle (,.

@VisLab
Copy link
Member Author

VisLab commented Nov 4, 2024

@happy5214 I am going to merge this PR because it just has the tokenizer fixes we discussed. However, the CI Coverage is showing failed tests in the action. It might be because I added a .codeclimate.yaml to see if I could get the coverage to work. Also it was trying to compute coverage on some of the tests. Can you look at this and see if you can spot the configuration issues.

All of the tests in tests pass locally.

@VisLab VisLab merged commit 84fd711 into hed-standard:develop Nov 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant