Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HED 2 support and reorganize code #216

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

happy5214
Copy link
Member

This PR removes support for HED 2 and overhauls the code organization. The schema code is now collected in a new top-level folder, and several other files were renamed. The remote schema URLs were fixed due to a GitHub change.

@happy5214 happy5214 added enhancement New feature or request quality Code quality, not must-fix tests Issues related to testcases hed 3 HED 3-specific issues hed 2 HED 2-specific issues validation Tag validation issues schema Schema parsing parsing String parsing important Important issues labels Nov 6, 2024
@happy5214 happy5214 added this to the 3.15.6 milestone Nov 6, 2024
@happy5214 happy5214 requested a review from VisLab November 6, 2024 01:36
@happy5214 happy5214 self-assigned this Nov 6, 2024
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's do it.

@VisLab VisLab marked this pull request as ready for review November 6, 2024 11:57
@VisLab VisLab merged commit d97277f into hed-standard:develop Nov 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hed 2 HED 2-specific issues hed 3 HED 3-specific issues important Important issues parsing String parsing quality Code quality, not must-fix schema Schema parsing tests Issues related to testcases validation Tag validation issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants