Make maven-archiver compile scope #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Feb 24, 2024
romain-grecourt
pushed a commit
to romain-grecourt/helidon-build-tools
that referenced
this pull request
Oct 4, 2024
romain-grecourt
added a commit
that referenced
this pull request
Oct 4, 2024
Backport of #1070 to 3.x Also backport the following to ease the cherry picking: - Maven Archetype 3.3.0 compatibility #1070 - Pipeline updates #1056 - Inline spotbugs lifecycle #1046 - Helidon Archetype Maven Plugin - Update integration-test mojo #1043 - 4.x: Upgrade github actions to v4 #1037 - 4.x: Add Upload Staged Artifacts step to release workflow #1035 - Upgrade asm to 9.5 and asciidoctorj to 2.5.11 #1029 - Guava upgrade #1027 - Upgrade maven-core and other maven libs to 3.8.8 #1025 - Make maven-archiver compile scope #1024 - Cleanup and dependency reduction #1023 - Dependency upgrade pass 2 #1022 - Upgrade snakeyaml to 2.0 #1021 - Remove support for site lifecycle and dependency on doxia #1020 - Add dependency check plugin #1019 - Uptake Maven 3.9.x #1004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #1020. That PR removed a dependency on the
maven-site-plugin. As it turns out, the site plugin was bringing some transitive dependencies we needed at runtime (like maven-archiver and plexus-archiver stuff). So we change maven-archiver to compile scope so it (and plexus archiver) are now present at runtime.This was discovered when trying to build the Helidon docs and getting exceptions like