Skip to content

Commit

Permalink
Squashable commit; fixed spotbugs
Browse files Browse the repository at this point in the history
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
  • Loading branch information
ljnelson committed Nov 2, 2023
1 parent f983de9 commit 250ac95
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions integrations/cdi/hibernate-cdi/etc/spotbugs/exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,20 @@
-->
<Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
</Match>
<Match>
<Class name="io.helidon.integrations.cdi.hibernate.DataSourceBackedDialectFactory"/>
<!--
In the following construct:
try (Connection c = ds.getConnection()) {
dmd = c.getMetaData();
} catch (SQLException e) {
throw BasicSQLExceptionConverter.INSTANCE.convert(e);
}
Spotbugs reports an unnecessary null check on the line containing "catch (SQLException e)". My guess is it
is confused by the bytecodes emitted by the try-with-resources source construct. In any event, it is wrong.
-->
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
</Match>
</FindBugsFilter>

0 comments on commit 250ac95

Please sign in to comment.