Restore percentile and bucket data to JSON metrics output #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
reviewed
Oct 19, 2023
| @@ -471,6 +475,42 @@ protected void apply(JsonObjectBuilder builder) { | |||
| builder.add(meterId.name(), sameNameBuilder); | |||
| } | |||
|
|
|||
| private void addDetails(HistogramSnapshot snapshot, Meter.Id childId, TimeUnit timeUnit) { | |||
| snapshot.percentileValues().forEach(vap -> | |||
| sameNameBuilder | |||
There was a problem hiding this comment.
IMO, all these new lines don't make this code fragment more readable. I would make this code a bit less sparse.
spericas
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7848
I had to rewrite the JSON metrics output code for 4.x but accidentally omitted the percentile and bucket output. (It's fine in the Prometheus/OpenMetrics output because we rely on the Micrometer Prometheus meter registry for that in 4.x.)
This PR adds the missing output back.
Documentation
No impact (outside of already-in-progress metrics doc revs).