Skip to content

Remove mirrors requirement to allow for dart aot #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EricApostal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove mirrors requirement to allow for dart aot #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9ea9fe
remove mirrors requirement maybe
EricApostal Dec 7, 2025
c944602
reliable symbol value
EricApostal Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/implementation/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,14 @@ packages:
path: "../../packages/lyell"
relative: true
source: path
version: "1.4.5"
version: "1.4.6"
lyell_gen:
dependency: "direct overridden"
description:
path: "../../packages/lyell_gen"
relative: true
source: path
version: "3.0.10"
version: "3.0.12"
matcher:
dependency: transitive
description:
Expand Down
7 changes: 4 additions & 3 deletions packages/lyell_gen/lib/src/imports.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'dart:mirrors';

import 'package:analyzer/dart/constant/value.dart';
import 'package:analyzer/dart/element/element2.dart';
import 'package:analyzer/dart/element/type.dart' as analyzer_type;
Expand Down Expand Up @@ -219,7 +217,10 @@ abstract class TypeStringifier {
if (reader.isBool) return reader.boolValue.toString();
if (reader.isString) return "'${sqsLiteralEscape(reader.stringValue)}'";

if (reader.isSymbol) return "#${MirrorSystem.getName(reader.symbolValue)}";
if (reader.isSymbol) {
final name = reader.objectValue.toSymbolValue();
return "#$name";
}
if (reader.isType) return get(reader.typeValue);
if (object.variable2 != null) {
var variable = object.variable2!;
Expand Down
Loading