Alternate approach to passing in clients #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madninja
force-pushed
the
madninja/updates-fixups
branch
from
c7b0f0c
to
281c6a5
Compare
This uses a wrapper Client but specific AsRef declations in each of the public facing functions in the library
madninja
force-pushed
the
madninja/updates-fixups
branch
from
281c6a5
to
380e6ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how clients are passed into the public library functions. Rather than specific settings and constructing clients, the new approach is to use
AsRef<SolanaRpcClient>and similar to access functions from the given client reference. This allows for reuse of clients.The PR also removes/limits the use of the anchor_client since it constructs its own clients, isn't very async friendly and the conveniences it offers aren't that valuable in this library